[ZEPPELIN-6520] Bind repository proxy password input to proxyPassword control#5291
Merged
Conversation
… control The proxy Password input in the interpreter add-repository modal was bound to the proxyLogin form control, so a proxy password could never be saved and typing one overwrote the proxy login. Bind the Password input to the proxyPassword control so both proxy credentials are submitted. Add a Playwright e2e regression test that fills the proxy login and password and asserts the add-repository request carries each value in its own field. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In the interpreter "add repository" dialog, the proxy Password input was bound to the wrong reactive-form control (
proxyLogin) — the same control the Login field already uses. As a result a proxy password could never be saved, and typing a proxy password overwrote the proxy login.This PR binds the Password input to the
proxyPasswordcontrol so that both proxy credentials are submitted independently.create-repository-modal.component.html:What type of PR is it?
Bug Fix
Todos
What is the ticket?
https://issues.apache.org/jira/browse/ZEPPELIN-6520
How should this be tested?
cd zeppelin-web-angular && npm run linte2e/tests/workspace/interpreter/create-repository-proxy-credentials.spec.ts. It fills the proxy login and proxy password in the add-repository modal and asserts thePOST /api/interpreter/repositorypayload carries each value in its own field (proxyLogin/proxyPassword). The test fails on the current binding and passes with this fix.Screenshots (if appropriate)
N/A — the form renders identically; the defect is only visible in the submitted payload.
Questions: